Skip to content

Bug 2050946: Fix wrong informer for feature-gate-stopper #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 10, 2022
Merged

Bug 2050946: Fix wrong informer for feature-gate-stopper #739

openshift-merge-robot merged 1 commit into from
Feb 10, 2022

Conversation

@lobziik
Copy link
Contributor

@lobziik lobziik commented Feb 10, 2022

cvInformer does not make sense for FeatureGate due to it filters out resources with name other than version by default,
which leads to the fact that FeatureGate will not be found there:

cluster-version-operator/pkg/featurechangestopper/techpreviewchangestopper.go

Line 65 in a44a3c0

if featureGates, err := c.featureGateLister.Get("cluster"); err == nil {

even in case if it is presented in the cluster.

@lobziik
Pass sharedInfromer instead of cvInformer to feature-gate-stopper
12eeab3 
cvInformer does not make sense for FeatureGate due to it filters
out resources with name other than `version` by default.
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Feb 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2022

@lobziik: This pull request references Bugzilla bug 2050946, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jiajliu

Details

In response to this:

Bug 2050946: Pass sharedInfromer instead of cvInformer to feature-gate-stopper

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 10, 2022
@openshift-ci openshift-ci bot requested a review from jiajliu February 10, 2022 16:52
@lobziik lobziik changed the title Bug 2050946: Pass sharedInfromer instead of cvInformer to feature-gate-stopper Bug 2050946: Fix wrong informer for feature-gate-stopper Feb 10, 2022
@lobziik
Copy link
Contributor Author

lobziik commented Feb 10, 2022

/cc @alexander-demichev @wking

wking
wking approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lobziik, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 10, 2022
@wking
Copy link
Member

wking commented Feb 10, 2022

KubePersistentVolumeErrors and LB availability are unrelated.

/override ci/prow/e2e-agnostic
/override ci/prow/e2e-agnostic-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2022

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic, ci/prow/e2e-agnostic-upgrade

Details

In response to this:

KubePersistentVolumeErrors and LB availability are unrelated.

/override ci/prow/e2e-agnostic
/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2022

@lobziik: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit b133d82 into openshift:master Feb 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2022

@lobziik: All pull requests linked via external trackers have merged:

Bugzilla bug 2050946 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2050946: Fix wrong informer for feature-gate-stopper

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking mentioned this pull request Feb 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wking wking wking approved these changes

@jiajliu jiajliu Awaiting requested review from jiajliu

@LalatenduMohanty LalatenduMohanty Awaiting requested review from LalatenduMohanty

@vrutkovs vrutkovs Awaiting requested review from vrutkovs

@alexander-demicev alexander-demicev Awaiting requested review from alexander-demicev

Assignees

@wking wking

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lobziik @wking @openshift-merge-robot